-
Notifications
You must be signed in to change notification settings - Fork 615
add softshrink kernel #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
# Copyright 2019 The TensorFlow Authors. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# ============================================================================== | ||
|
||
from __future__ import absolute_import | ||
from __future__ import division | ||
from __future__ import print_function | ||
|
||
import tensorflow as tf | ||
from tensorflow_addons.utils import keras_utils | ||
from tensorflow_addons.utils.resource_loader import get_path_to_datafile | ||
|
||
_activation_ops_so = tf.load_op_library( | ||
get_path_to_datafile("custom_ops/activations/_activation_ops.so")) | ||
|
||
|
||
@keras_utils.register_keras_custom_object | ||
@tf.function | ||
def softshrink(x, lower=-1.0, upper=1.0): | ||
"""Soft shrink function. | ||
|
||
Computes soft shrink function: | ||
`x - lower if x < lower, x - upper if x > upper else 0`. | ||
|
||
Args: | ||
x: A `Tensor`. Must be one of the following types: | ||
`float16`, `float32`, `float64`. | ||
lower: `float`, lower bound for setting values to zeros. | ||
upper: `float`, upper bound for setting values to zeros. | ||
Returns: | ||
A `Tensor`. Has the same type as `x`. | ||
""" | ||
x = tf.convert_to_tensor(x) | ||
return _activation_ops_so.addons_softshrink(x, lower, upper) | ||
|
||
|
||
@tf.RegisterGradient("Addons>Softshrink") | ||
def _softshrink_grad(op, grad): | ||
return _activation_ops_so.addons_softshrink_grad(grad, op.inputs[0], | ||
op.get_attr("lower"), | ||
op.get_attr("upper")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
# Copyright 2019 The TensorFlow Authors. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
# ============================================================================== | ||
|
||
from __future__ import absolute_import | ||
from __future__ import division | ||
from __future__ import print_function | ||
|
||
from absl.testing import parameterized | ||
|
||
import numpy as np | ||
import tensorflow as tf | ||
from tensorflow_addons.activations import softshrink | ||
from tensorflow_addons.utils import test_utils | ||
|
||
|
||
@test_utils.run_all_in_graph_and_eager_modes | ||
class SoftshrinkTest(tf.test.TestCase, parameterized.TestCase): | ||
def test_invalid(self): | ||
with self.assertRaisesOpError( | ||
"lower must be less than or equal to upper."): # pylint: disable=bad-continuation | ||
y = softshrink(tf.ones(shape=(1, 2, 3)), lower=2.0, upper=-2.0) | ||
self.evaluate(y) | ||
|
||
@parameterized.named_parameters(("float16", np.float16), | ||
("float32", np.float32), | ||
("float64", np.float64)) | ||
def test_softshrink(self, dtype): | ||
x = tf.constant([-2.0, -1.0, 0.0, 1.0, 2.0], dtype=dtype) | ||
expected_result = tf.constant([-1.0, 0.0, 0.0, 0.0, 1.0], dtype=dtype) | ||
self.assertAllCloseAccordingToType(softshrink(x), expected_result) | ||
|
||
expected_result = tf.constant([-1.5, -0.5, 0.0, 0.5, 1.5], dtype=dtype) | ||
self.assertAllCloseAccordingToType( | ||
softshrink(x, lower=-0.5, upper=0.5), expected_result) | ||
|
||
@parameterized.named_parameters(("float32", np.float32), | ||
("float64", np.float64)) | ||
def test_theoretical_gradients(self, dtype): | ||
# Only test theoretical gradients for float32 and float64 | ||
# because of the instability of float16 while computing jacobian | ||
|
||
# Softshrink is not continuous at `lower` and `upper`. | ||
# Avoid these two points to make gradients smooth. | ||
x = tf.constant([-2.0, -1.5, 0.0, 1.5, 2.0], dtype=dtype) | ||
|
||
theoretical, numerical = tf.test.compute_gradient(softshrink, [x]) | ||
self.assertAllCloseAccordingToType(theoretical, numerical, atol=1e-4) | ||
|
||
def test_unknown_shape(self): | ||
fn = softshrink.get_concrete_function( | ||
tf.TensorSpec(shape=None, dtype=tf.float32)) | ||
|
||
for shape in [(1,), (1, 2), (1, 2, 3), (1, 2, 3, 4)]: | ||
x = tf.ones(shape=shape, dtype=tf.float32) | ||
self.assertAllClose(fn(x), softshrink(x)) | ||
|
||
|
||
if __name__ == "__main__": | ||
tf.test.main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
81 changes: 81 additions & 0 deletions
81
tensorflow_addons/custom_ops/activations/cc/kernels/softshrink_op.cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
/* Copyright 2019 The TensorFlow Authors. All Rights Reserved. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
==============================================================================*/ | ||
|
||
#define EIGEN_USE_THREADS | ||
|
||
#include "tensorflow_addons/custom_ops/activations/cc/kernels/softshrink_op.h" | ||
#include "tensorflow/core/framework/op_kernel.h" | ||
#include "tensorflow/core/framework/register_types.h" | ||
#include "third_party/eigen3/unsupported/Eigen/CXX11/Tensor" | ||
|
||
namespace tensorflow { | ||
namespace addons { | ||
|
||
using CPUDevice = Eigen::ThreadPoolDevice; | ||
|
||
#define REGISTER_SOFTSHRINK_KERNELS(type) \ | ||
REGISTER_KERNEL_BUILDER( \ | ||
Name("Addons>Softshrink").Device(DEVICE_CPU).TypeConstraint<type>("T"), \ | ||
SoftshrinkOp<CPUDevice, type>); \ | ||
REGISTER_KERNEL_BUILDER(Name("Addons>SoftshrinkGrad") \ | ||
.Device(DEVICE_CPU) \ | ||
.TypeConstraint<type>("T"), \ | ||
SoftshrinkGradOp<CPUDevice, type>); | ||
|
||
// Softshrink only makes sense with floating points. | ||
TF_CALL_GPU_NUMBER_TYPES(REGISTER_SOFTSHRINK_KERNELS); | ||
#undef REGISTER_SOFTSHRINK_KERNELS | ||
|
||
#if GOOGLE_CUDA | ||
|
||
using GPUDevice = Eigen::GpuDevice; | ||
|
||
// Forward declarations of the functor specializations for GPU. | ||
namespace functor { | ||
#define DECLARE_GPU_SPEC(T) \ | ||
template <> \ | ||
void Softshrink<GPUDevice, T>::operator()( \ | ||
const GPUDevice& d, typename TTypes<T>::ConstTensor features, T lower, \ | ||
T upper, typename TTypes<T>::Tensor activations); \ | ||
extern template struct Softshrink<GPUDevice, T>; \ | ||
\ | ||
template <> \ | ||
void SoftshrinkGrad<GPUDevice, T>::operator()( \ | ||
const GPUDevice& d, typename TTypes<T>::ConstTensor gradients, \ | ||
typename TTypes<T>::ConstTensor features, T lower, T upper, \ | ||
typename TTypes<T>::Tensor backprops); \ | ||
extern template struct SoftshrinkGrad<GPUDevice, T>; | ||
|
||
TF_CALL_GPU_NUMBER_TYPES(DECLARE_GPU_SPEC); | ||
#undef DECLARE_GPU_SPEC | ||
} // namespace functor | ||
|
||
// Registration of the GPU implementations. | ||
#define REGISTER_SOFTSHRINK_GPU_KERNELS(type) \ | ||
REGISTER_KERNEL_BUILDER( \ | ||
Name("Addons>Softshrink").Device(DEVICE_GPU).TypeConstraint<type>("T"), \ | ||
SoftshrinkOp<GPUDevice, type>); \ | ||
REGISTER_KERNEL_BUILDER(Name("Addons>SoftshrinkGrad") \ | ||
.Device(DEVICE_GPU) \ | ||
.TypeConstraint<type>("T"), \ | ||
SoftshrinkGradOp<GPUDevice, type>); | ||
|
||
TF_CALL_GPU_NUMBER_TYPES(REGISTER_SOFTSHRINK_GPU_KERNELS); | ||
#undef REGISTER_SOFTSHRINK_GPU_KERNELS | ||
|
||
#endif // GOOGLE_CUDA | ||
|
||
} // namespace addons | ||
} // namespace tensorflow |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any intuition on defaulting to
1.0
? The link you posted (which references pytorch) has a default of0.5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also 0.5 default in PaddlePaddle:
https://github.com/PaddlePaddle/Paddle/blob/master/paddle/fluid/operators/activation_op.cc#L251
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably no... It's my mistake on both
hardshrink
andsoftshrink
though I could not find any research paper about the value0.5
. Will change them to0.5
later.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. Also couldn't find any rationale for
0.5
other than framework defaults.