Criteria for doing API reviews and design reviews in TF #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextp
requested review from
brijk7,
ewilderj,
martinwicke and
theadactyl
as code owners
brijk7
approved these changes
Dec 6, 2019
|
This may need a little extra elaboration to explain terms to non-TensorFlow team members . Tagging in @theadactyl for her opinion. |
MarkDaoust
reviewed
Dec 9, 2019
shoyer
reviewed
Dec 9, 2019
martinwicke
approved these changes
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These documents show what we mostly look for in API reviews and design reviews in general. They should be edited in the future as our practices change.