Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a standard CONTRIBUTING.md template #384

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

bhack
Copy link
Contributor

@bhack bhack commented Apr 21, 2021

This is a Draft CONTRIBUTING.md template.
It is part of an effort to standardize some early access info for Github community health files across the TensorFlow ecosystem repositories.

@google-cla google-cla bot added the cla: yes label Apr 21, 2021
@bhack
Copy link
Contributor Author

bhack commented Apr 21, 2021

/cc @ematejska @theadactyl I don't have write access here. Can you convert to draft? Thanks

@theadactyl theadactyl marked this pull request as draft April 21, 2021 18:41
@bhack bhack changed the title CONTRIBUTING.md template Add a standard CONTRIBUTING.md template Apr 29, 2021
## CODEOWNERS
Describe how codeownership and maintainership in the repo:
* How to be a Codeowner
* How to be a Maintainer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to suggest we consider adding this as a separate file (CALL_FOR_MAINTAINERS.md?) due to the importance of the role.

Copy link
Contributor Author

@bhack bhack Jun 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, we could put here just a like to an external markdown.
I don't know if we could open a new thread later about standardizing a little bit the CALL_FOR_MAINTAINERS process/roles.

E.g. Debian has historically a quite regulated Maintainer process. This is just to make a reference example but it is too complex for us.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc I think that also @mihaimaruseac could be interested in the Codeowner/Maintainer status and process.

@bhack
Copy link
Contributor Author

bhack commented Oct 27, 2021

/cc @lamberta for a review

@ematejska
Copy link
Contributor

@bhack Is this ready for review or still a draft?

@bhack
Copy link
Contributor Author

bhack commented Dec 9, 2021

I don't know how to collect early feedback.
What do you think @theadactyl @yarri-oss?

@theadactyl
Copy link
Contributor

theadactyl commented Dec 9, 2021 via email

@ematejska
Copy link
Contributor

@theadactyl Can you review?

@bhack
Copy link
Contributor Author

bhack commented Feb 1, 2022

Just a reminder for the reviewers. We need to figure out also how to handle topics mentioned in #223

I suppose we could add a general point in this template if we could define some general rules on how to handle duplicated/conflicting contributions.

@bhack bhack mentioned this pull request Feb 11, 2022
This was referenced Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants