Skip to content

Conversation

NikhilBartwal
Copy link
Contributor

@NikhilBartwal NikhilBartwal commented May 2, 2021

Closes #3195, closes #3203, closes #3219
The train and test URL was changed and the URL checksums re-generated. The dataset is generated successfully now.

@google-cla google-cla bot added the cla: yes Author has signed CLA label May 2, 2021
@NikhilBartwal
Copy link
Contributor Author

NikhilBartwal commented May 2, 2021

Hey @Conchylicultor, there seems to be an issue with the way checksums are currently updated when using

tfds build dataset_name --register_checksums

as the new checksums, instead of replacing the old ones, are only appended with them.

I think this stems from this:

Content of file is never disgarded, only updated. This is to ensure that if

As the new checksums are only appended and then stored in sorted order along with the old checksums.

I will update the checksums for this dataset manually for now but we might need to look into this. Thanks!

Copy link

@Tejas-Beedkar Tejas-Beedkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New links verified.

@tfds-copybara tfds-copybara merged commit 903e03b into tensorflow:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Author has signed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cars196 link broken - needs updating [data request] <cars196> TFDS link broken for Cars196
3 participants