Skip to content

Set both names and IDs in mlc's test fixtures. #5618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −2
Open

Set both names and IDs in mlc's test fixtures. #5618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tensorflow_datasets/core/utils/croissant_utils_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def test_get_split_recordset():
),
mlc.RecordSet(
id='splits',
key='name',
key='splits/name',
data_types=[mlc.DataType.SPLIT],
fields=[
mlc.Field(
Expand All @@ -95,7 +95,7 @@ def test_get_split_recordset_with_no_split_recordset():
record_sets = [
mlc.RecordSet(
id='labels',
key='name',
key='labels/label',
fields=[
mlc.Field(
id='labels/label',
Expand Down
4 changes: 4 additions & 0 deletions tensorflow_datasets/testing/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -736,6 +736,7 @@ def dummy_croissant_file(

fields = [
mlc.Field(
id='index',
name='index',
description='The sample index.',
data_types=mlc.DataType.INTEGER,
Expand All @@ -745,6 +746,7 @@ def dummy_croissant_file(
),
),
mlc.Field(
id='text',
name='text',
description='The dummy sample text.',
data_types=mlc.DataType.TEXT,
Expand All @@ -758,6 +760,7 @@ def dummy_croissant_file(
record_sets = [
mlc.RecordSet(
id='jsonl',
name='jsonl',
description='Dummy record set.',
fields=fields,
)
Expand All @@ -778,6 +781,7 @@ def dummy_croissant_file(
distribution = [
mlc.FileObject(
id='raw_data',
name='raw_data',
description='File with the data.',
encoding_format='application/jsonlines',
content_url=f'data/{raw_data_filename}',
Expand Down
Loading