Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bfloat16 support for Intel CPUs #2209

Closed

Conversation

gaurides
Copy link
Contributor

@gaurides gaurides commented Mar 24, 2023

This PR updates mixed_precision documentation to reflect that Intel CPU Sapphire Rapids supports BFloat16 optimizations using AMX instructions and user can expect performance boost.
It doesn't affect any other part of the document.

@gaurides gaurides requested a review from a team as a code owner March 24, 2023 01:33
@github-actions
Copy link

Preview

Preview and run these notebook edits with Google Colab: Rendered notebook diffs available on ReviewNB.com.

Format and style

Use the TensorFlow docs notebook tools to format for consistent source diffs and lint for style:
$ python3 -m pip install -U --user git+https://github.com/tensorflow/docs

$ python3 -m tensorflow_docs.tools.nbfmt notebook.ipynb
$ python3 -m tensorflow_docs.tools.nblint --arg=repo:tensorflow/docs notebook.ipynb
If commits are added to the pull request, synchronize your local branch: git pull origin gaurides/mixedprecision_doc

@gaurides
Copy link
Contributor Author

@penpornk : Can you please review this PR to update documentation?

@gaurides
Copy link
Contributor Author

gaurides commented May 9, 2023

@penpornk, @8bitmp3 - Please let me know if you have any questions. Thanks.

@penpornk
Copy link
Member

@MarkDaoust Could you please help review this mixed precision doc update? :)
Contents look okay to me. Wording-wise, I'm not sure if some parts are clear enough to general TF readers (or if they need more explanations).

MarkDaoust
MarkDaoust previously approved these changes Jul 17, 2023
site/en/guide/mixed_precision.ipynb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the lgtm Community-added approval label Jul 17, 2023
@MarkDaoust MarkDaoust added ready to pull Start merge process and removed awaiting-technical-review labels Jul 17, 2023
@MarkDaoust
Copy link
Member

Thanks for the ping. I think its okay, let's get this merged, it's been waiting long enough.

include suggested changes

Co-authored-by: Mark Daoust <markdaoust@google.com>
@gaurides
Copy link
Contributor Author

@MarkDaoust - I included your suggestion. Can you please re-approve? Thanks.

Copy link
Member

@MarkDaoust MarkDaoust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@MarkDaoust MarkDaoust added ready to pull Start merge process and removed ready to pull Start merge process labels Jul 17, 2023
@gaurides gaurides closed this Jul 17, 2023
copybara-service bot pushed a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Community-added approval ready to pull Start merge process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants