Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kafka] improve verbosity while rebalancing consumers #1166

Merged
merged 1 commit into from
Oct 31, 2020
Merged

[kafka] improve verbosity while rebalancing consumers #1166

merged 1 commit into from
Oct 31, 2020

Conversation

kvignesh1420
Copy link
Member

@kvignesh1420 kvignesh1420 commented Oct 31, 2020

This PR improves the log information while using the KafkaGroupIODataset and KafkaBatchIODataset by improving the verbosity of the message while rebalancing consumers. This prevents confusion and enables users to track offsets and error codes.

current log:

REBALANCE: key-partition-test[0], 5 0

new log:

REBALANCE: key-partition-test[0], OFFSET: 5 ERROR_CODE: 0

@kvignesh1420
Copy link
Member Author

The failed task has been addressed in #1167

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvignesh1420 kvignesh1420 merged commit d258989 into tensorflow:master Oct 31, 2020
@kvignesh1420 kvignesh1420 deleted the kafka-log branch October 31, 2020 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants