Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update bazel to 0.26.1, and update google cpp to v0.9.0 #284

Closed
wants to merge 1 commit into from

Conversation

yongtang
Copy link
Member

@yongtang yongtang commented Jun 9, 2019

This fix fixes #248

Signed-off-by: Yong Tang yong.tang.github@outlook.com

@yongtang yongtang changed the title Update bazel to 0.26.1, and update google cpp to v0.9.0 [WIP] Update bazel to 0.26.1, and update google cpp to v0.9.0 Jun 9, 2019
@yongtang
Copy link
Member Author

yongtang commented Jun 9, 2019

Update, looks like Bazel 0.26.1 may have bugs in macOS. Update on hold.

@damienpontifex
Copy link
Contributor

@yongtang I've been using bazel 0.27 on macOS without any current issues. Worth skipping straight to that if you're seeing issues here?

@yongtang
Copy link
Member Author

Thanks @damienpontifex. I just tried bazel 0.27.0 and see it fails on Ubuntu 14.04:

# bazel build -s --verbose_failures //tensorflow_io/core:all
/usr/local/bin/bazel: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.21' not found (required by /usr/local/bin/bazel)
/usr/local/bin/bazel: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `CXXABI_1.3.8' not found (required by /usr/local/bin/bazel)
/usr/local/bin/bazel: /usr/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /usr/local/bin/bazel)

Related: bazelbuild/bazel#8652

Give TensorFlow binaries are still built on Ubuntu 14.04 (and not truly compatible with Ubuntu 16.04+), we may have to wait until this is fixed. I think even TensorFlow main repo will be impacted.

@damienpontifex
Copy link
Contributor

@yongtang I noticed that linked issue is now closed. Any success on bazel 0.27.1 ?

@yongtang
Copy link
Member Author

@damienpontifex with Bazel 0.27.1 the following error surfaced:

ERROR: /v/tensorflow_io/grpc/BUILD:31:1: in _generate_cc rule //tensorflow_io/grpc:_endpoint_cc_grpc_codegen: 
Traceback (most recent call last):
	File "/v/tensorflow_io/grpc/BUILD", line 31
		_generate_cc(name = '_endpoint_cc_grpc_codegen')
	File "/root/.cache/bazel/_bazel_root/a7ecd8237744645c5d189c197108d6d2/external/com_github_grpc_grpc/bazel/generate_cc.bzl", line 44, in generate_cc_impl
		[f for src in ctx.attr.srcs for f in src.proto.check_deps_sources]
type 'depset' is not iterable. Use the `to_list()` method to get a list. Use --incompatible_depset_is_not_iterable=false to temporarily disable this check.
ERROR: Analysis of target '//tensorflow_io/grpc:_endpoint_cc_grpc_codegen' failed; build aborted: Analysis of target '//tensorflow_io/grpc:_endpoint_cc_grpc_codegen' failed; build aborted

This error likely has been fixed in (grpc/grpc@49f0fb9) though it is not in the release of grpc yet.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
@yongtang
Copy link
Member Author

yongtang commented Sep 8, 2019

With PR #465 merged, now we are in bazel 0.29.0 with googleapi/grpc all updated to the latest. This PR could be closed.

@yongtang yongtang closed this Sep 8, 2019
@yongtang yongtang deleted the 0.26.1 branch January 20, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build with bazel 0.25.3 fails
2 participants