Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
NdArray.read(dstBuffer)
toNdArray.copyTo(dstBuffer)
, andNdArray.write(srcBuffer)
toNdArray.copyFrom(srcBuffer)
, to make more obvious the direction of the data flow of these methods.This is somehow related to tensorflow/java#510, though I just modified the signature in
NdArray
and left the one inDataBuffer
intact, since theread/write
methods of these entities tries to replicate the behaviour of theget/put
methods of the Java NIO buffers.