Skip to content

Missing Lint checks in new build for TensorFlow #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
karllessard opened this issue Dec 14, 2019 · 1 comment
Open

Missing Lint checks in new build for TensorFlow #7

karllessard opened this issue Dec 14, 2019 · 1 comment

Comments

@karllessard
Copy link
Collaborator

When we migrated to tensorflow/java and to Maven, we dropped a few rules that were embedded in the Bazel configuration of the previous build. One of them is all the link checks that are listed in (this file)[https://github.com/tensorflow/tensorflow/blob/master/tensorflow/java/build_defs.bzl]

This issue is a placeholder to remember that those should probably be added back to the new Maven build.
@karllessard karllessard mentioned this issue Dec 14, 2019
Merged
@karllessard karllessard mentioned this issue Jan 20, 2020
Merged
@karllessard karllessard mentioned this issue Sep 7, 2020
Merged
@karllessard
Copy link
Collaborator Author

karllessard commented Oct 8, 2020 •
edited
Loading

We must check at the doclints as well

@karllessard karllessard mentioned this issue Oct 8, 2020
Merged
deansher pushed a commit to deansher/java that referenced this issue Mar 3, 2021
@JimClarke5
Merge pull request tensorflow#7 from tensorflow/master
04f419a 
pull type def
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karllessard