Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix decoding of string length #138

Merged
merged 1 commit into from
Oct 30, 2020
Merged

Conversation

brychcy
Copy link
Contributor

@brychcy brychcy commented Oct 30, 2020

When turning tensors with length > 127 into java Strings, they were truncated.

Patch contains an added test case with an example.

Copy link
Collaborator

@karllessard karllessard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brychcy !

@karllessard karllessard merged commit 91400f4 into tensorflow:master Oct 30, 2020
@brychcy
Copy link
Contributor Author

brychcy commented Nov 9, 2020

Can you pleeeease make a release with this soonish? This is the only issue that stops us from switching to these awesome new bindings.
(I tried using the snapshots, but that doesn't work with our corporate setup.)

@karllessard
Copy link
Collaborator

karllessard commented Nov 11, 2020

Hi @brychcy, I would honestly be pleased to unblock you that quickly but our release process is not currently up-to-speed and I personally don't have the bandwidth for doing another one right now (releasing projects with native artifacts like TF is not as straightforward as any standard Java/Maven projects)

I'm following up with Google right now to get more resources available so we can do quick releases like this. Hopefully, these will be unblocked soon, I'll let you know.

cc\ @joanafilipa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants