Change eager mode control inputs from exception to no-op, reflecting eager semantics. #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eager semantics. Signed-off-by: Ryan Nett <rnett@calpoly.edu>
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
rnett
added a commit
to rnett/tensorflow-java
that referenced
this pull request
Dec 28, 2020
…eager semantics. (tensorflow#158) * Change eager mode control inputs from exception to no-op, reflecting eager semantics. Signed-off-by: Ryan Nett <rnett@calpoly.edu> * fix test to reflect not throwing exception Signed-off-by: Ryan Nett <rnett@calpoly.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple PR to fix #157. Makes adding control inputs in eager mode a no-op instead of an exception, for the reasons described in the issue (since it's eager mode, any control deps being added will already have been computed).