Better cross-environment error messages #207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
|
@rnett , I agree the broken test seems reverted, it should fail if there are no exception thrown, that is strange. You can update it or simply remove it since you seem to cover these cases in another test suite now. |
Signed-off-by: Ryan Nett <rnett@calpoly.edu>
Closed
|
It's fixed, should be good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes
env()toOperationandOp, and adds nicer error messages when using inputs from other environments.@karllessard it's currently failing the
failWhenMixingOperationsOnDifferentGraphstest, but looking at it it looks like the test is wrong. It fails when an exception is thrown, which given the name seems backwards. Mixing graphs like this fails anyways, just not until the session is ran (it gives a very crypticGraph is invalid, contains a cycleexception, but I'm assuming that's due to the mixing).