Skip to content

Export ops.pbtxt in addition to ops.pb #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 30, 2021

Conversation

rnett
Copy link
Contributor

@rnett rnett commented Apr 29, 2021

#305, but done properly. The ops.pbtxt isn't used by the generator, but it's good to have as documentation and for git diffs.

…sting

Signed-off-by: Ryan Nett <rnett@calpoly.edu>
@rnett
Copy link
Contributor Author

rnett commented Apr 29, 2021

@karllessard this needs CI Build.

@rnett
Copy link
Contributor Author

rnett commented Apr 29, 2021

The failure looks like an actions issue, it's working on some platforms and I didn't change anything platform-specific.

@karllessard
Copy link
Collaborator

Hey @rnett , there is a lot of undesirable reformatting in your PR, can you please turn it off and resubmit?

rnett added 2 commits April 29, 2021 14:01
Signed-off-by: Ryan Nett <JNett96@gmail.com>
Signed-off-by: Ryan Nett <JNett96@gmail.com>
@karllessard
Copy link
Collaborator

yeah ok, something seems wrong on the Windows platform but yeah, probably unrelated... (sigh)

let's merge then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants