-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to TF 2.10.1, with macosx-arm64 support #481
Conversation
tensorflow-core/tensorflow-core-api/src/bazel/op_generator/op_export_main.cc
Show resolved
Hide resolved
tensorflow-core/tensorflow-core-api/src/gen/annotations/org/tensorflow/op/Ops.java
Outdated
Show resolved
Hide resolved
tensorflow-core/tensorflow-core-api/src/gen/java/org/tensorflow/internal/c_api/Node.java
Show resolved
Hide resolved
tensorflow-core/tensorflow-core-api/src/gen/java/org/tensorflow/op/core/ApproxTopK.java
Outdated
Show resolved
Hide resolved
As 2.10/2.11 get merged in we might want to think about how to expose the new model fingerprint support, and if we can generate similar fingerprints from TF-Java - https://github.com/tensorflow/community/blob/master/rfcs/20220610-saved-model-fingerprinting.md. |
Linux GPU was failing to build, looks like this is a known problem and I've applied a patch found here that might fix it, we'll see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming we get a clean CI build.
There is an issue with the |
Ok, works in Linux and MacOS now, but for Windows I need to merge it first so the builds can continue over 6 hours. I'll repair after if needed. |
This PR does (a bit unfortunately) two different things:
I tried to upgrade to the now released TF 2.11.0 but hit a bunch of new problems which I want to deal with later, let's get at least MacOX ARM64 build working with a still recent version of TensorFlow (2.10.1)
Addresses #394 and #252