-
Notifications
You must be signed in to change notification settings - Fork 89
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @sklin93, thank you for this contribution! As google-cla bot mentioned, please sign a Contributor License Agreement (CLA) so we can take a look at your pull request. View this CLA check summary for more information. |
CLA signed! Please review and approve the pull request, thank you @codesue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this! Looks good in general, with a couple more places to update before merging:
- contributing guide (rebase for newer version)
- pull request template
- Scikit Learn demo notebook
- Standalone demo notebook
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you for checking! All changed. @codesue |
Please see #253 regarding renaming the default branch.