Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Make object_detection pip installable #4889

Closed
wants to merge 4 commits into from

Conversation

hadim
Copy link

@hadim hadim commented Jul 25, 2018

DO NOT MERGE

Following this issue #4887, I did a small test and everything seems to be ok to make the object_detection pip installable.

Protobuf files compilation works during pip installation (with or without the -e option): https://github.com/hadim/models/blob/535affae95d5da46b8819989cb6e1123d169d245/research/object_detection/setup.py#L18

The PR is pretty big because I add to move the Python files into a subdirectory called object_detection/.

I have also added an entry point for model_builder_test. Of course many more can be added if needed.

Note also the addition of an environment.yml file making the installation of deps much easier. People don't have to worry anymore about installing protobuf since it's available on Anaconda.

Important: at the moment this PR breaks the object_detection API code and model_builder_test returns an error when it is run. This is because the slim package provided by tensorflow seems to be older than the one provided by this repo. I don't have for the moment a good solution for this. I can suggest two options:

  1. Update the Tensorflow slim API to match the one provided on this repo.
  2. Make the slim package provided by this repo "official" and release it on PyPi. Then it's just a matter of adding slim as a pip dependency.

This PR is mainly for demonstration purpose.

@hadim hadim requested a review from derekjchow as a code owner July 25, 2018 01:01
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@hadim
Copy link
Author

hadim commented Jul 25, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@hadim hadim requested a review from sguada as a code owner July 27, 2018 23:23
@tfboyd
Copy link
Member

tfboyd commented Jan 18, 2019

6+ months old. Cleaning up a few PRs that show up if I filter for /official. While I do not think this touches official, closing this seemed like helpful cleanup. Ping me to reopen of desired. It was also tagged DO NOT MERGE in the title so I do not feel closing if going to offend you.

@tfboyd tfboyd closed this Jan 18, 2019
@hadim
Copy link
Author

hadim commented Jan 30, 2019

It does not offend me but that would be nice to consider/discuss on #4887.

@hadim hadim deleted the object_detection_pip branch October 14, 2019 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants