Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export benchmark stats using tf.test.Benchmark.report_benchmark() #6103

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Export benchmark stats using tf.test.Benchmark.report_benchmark() #6103

merged 2 commits into from
Feb 1, 2019

Conversation

lindong28
Copy link
Contributor

@lindong28 lindong28 commented Jan 28, 2019

This patch is needed for benchmark classes defined in EstimatorCifar10BenchmarkTests to be executed by PerfZero benchmark harness after we merge tensorflow/benchmarks#292.

@lindong28 lindong28 requested review from karmel and a team as code owners January 28, 2019 09:53
@lindong28 lindong28 requested a review from tfboyd January 28, 2019 09:54
@lindong28 lindong28 changed the title Return benchmark execution result as dict in benchmark function return value EstimatorCifar10BenchmarkTests should report benchmark results using tf.test.Benchmark.report_benchmark() Jan 30, 2019
@lindong28 lindong28 changed the title EstimatorCifar10BenchmarkTests should report benchmark results using tf.test.Benchmark.report_benchmark() Export benchmark statis using tf.test.Benchmark.report_benchmark() Feb 1, 2019
@lindong28 lindong28 changed the title Export benchmark statis using tf.test.Benchmark.report_benchmark() Export benchmark stats using tf.test.Benchmark.report_benchmark() Feb 1, 2019
@tfboyd tfboyd removed request for a team and karmel February 1, 2019 22:40
@tfboyd tfboyd merged commit a1bd019 into tensorflow:master Feb 1, 2019
tfboyd pushed a commit that referenced this pull request Feb 5, 2019
* Add resnet56 short tests. (#6101)

* Add resnet56 short tests.
- created base benchmark module
- renamed accuracy test class to contain the word Accuracy
which will result in a need to update all the jobs
and a loss of history but is worth it.
- short tests are mostly copied from shining with oss refactor

* Address feedback.

* Move flag_methods to init
- Address setting default flags repeatedly.

* Rename accuracy tests.

* Lint errors resolved.

* fix model_dir set to flags.data_dir.

* fixed not fulling pulling out flag_methods.

* Use core mirrored strategy in official models (#6126)

* Imagenet short tests (#6132)

* Add short imagenet tests (taken from seemuch)
- also rename to match go forward naming

* fix method name

* Update doc strings.

* Fixe gpu number.

* points default data_dir to child folder. (#6131)

Failed test is python2  and was a kokoro failure

* Imagenet short tests (#6136)

* Add short imagenet tests (taken from seemuch)
- also rename to match go forward naming

* fix method name

* Update doc strings.

* Fixe gpu number.

* Add fill_objects

* fixed calling wrong class in super.

* fix lint issue.

* Flag (#6121)

* Fix the turn_off_ds flag problem

* add param names to all args

* Export benchmark stats using tf.test.Benchmark.report_benchmark() (#6103)

* Export benchmark stats using tf.test.Benchmark.report_benchmark()

* Fix python style using pyformat

* Typos. (#6120)

* log verbosity=2 logs every epoch no progress bars (#6142)

* tf_upgrade_v2 on resnet and utils folder.

* tf_upgrade_v2 on resnet and utils folder.
w4-jonghoon pushed a commit to w4-jonghoon/models that referenced this pull request Feb 6, 2019
…nsorflow#6103)

* Export benchmark stats using tf.test.Benchmark.report_benchmark()

* Fix python style using pyformat
w4-jonghoon pushed a commit to w4-jonghoon/models that referenced this pull request Feb 6, 2019
* Add resnet56 short tests. (tensorflow#6101)

* Add resnet56 short tests.
- created base benchmark module
- renamed accuracy test class to contain the word Accuracy
which will result in a need to update all the jobs
and a loss of history but is worth it.
- short tests are mostly copied from shining with oss refactor

* Address feedback.

* Move flag_methods to init
- Address setting default flags repeatedly.

* Rename accuracy tests.

* Lint errors resolved.

* fix model_dir set to flags.data_dir.

* fixed not fulling pulling out flag_methods.

* Use core mirrored strategy in official models (tensorflow#6126)

* Imagenet short tests (tensorflow#6132)

* Add short imagenet tests (taken from seemuch)
- also rename to match go forward naming

* fix method name

* Update doc strings.

* Fixe gpu number.

* points default data_dir to child folder. (tensorflow#6131)

Failed test is python2  and was a kokoro failure

* Imagenet short tests (tensorflow#6136)

* Add short imagenet tests (taken from seemuch)
- also rename to match go forward naming

* fix method name

* Update doc strings.

* Fixe gpu number.

* Add fill_objects

* fixed calling wrong class in super.

* fix lint issue.

* Flag (tensorflow#6121)

* Fix the turn_off_ds flag problem

* add param names to all args

* Export benchmark stats using tf.test.Benchmark.report_benchmark() (tensorflow#6103)

* Export benchmark stats using tf.test.Benchmark.report_benchmark()

* Fix python style using pyformat

* Typos. (tensorflow#6120)

* log verbosity=2 logs every epoch no progress bars (tensorflow#6142)

* tf_upgrade_v2 on resnet and utils folder.

* tf_upgrade_v2 on resnet and utils folder.
@lindong28 lindong28 deleted the add-leading-indiciators-test branch February 22, 2019 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants