Final plumbing of multi-qubit control gates. #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBroughton
changed the title
This was referenced Jan 26, 2021
|
Bit of a bumpy ride to get things working. Plz make sure and do a thorough review. |
MichaelBroughton
changed the title
jaeyoo
previously approved these changes
Jan 27, 2021
There was a problem hiding this comment.
LGTM with minor change:
======================================================================
FAIL: test_correctness_without_symbols2 (n_qubits=5, batch_size=10, inner_dim_size=5) (__main__.InnerProductTest)
InnerProductTest.test_correctness_without_symbols2 (n_qubits=5, batch_size=10, inner_dim_size=5)
test_correctness_without_symbols(n_qubits=5, batch_size=10, inner_dim_size=5)
----------------------------------------------------------------------
please increase atol to 1e-5, for example.
jaeyoo
pushed a commit
to jaeyoo/quantum
that referenced
this pull request
Mar 30, 2023
Minor docs cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W.I.P PR for finishing off multi-qubit control gate support.
Currently blocked on quantumlib/qsim#263 for our unitary calculation op. Going to shelve this until we can upgrade the version of qsim we rely on if/when multi qubit gates are supported in the unitary calculator.Fixes #422