-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quantum embedding #606
Quantum embedding #606
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. Normally in our research branch, we like to see a simple application demonstration in the code. In the case of this embedding, would you mind setting up a simple training loop with a model and some data in order to show off how things work with the Layer ?
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
The unit tests already had a training loop, but it's a good point nonetheless, so I added a Jupyter notebook. PTAL. |
This PR tries to re-create a series of paper by Schuld et al. regarding the universality of quantum embeddings