Fix random.sample() usage with set for Python 3.11 compatibility (GH#887) #893
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a compatibility issue with Python 3.11 and above, where passing a set directly to random.sample() raises a TypeError.
In util.py, the open_qubits set is now explicitly converted to a list before being passed to random.sample() in the _apply_random_control function.
Audit of other random.sample() calls in util.py: No changes needed
Line 150: qubits is expected to be a list or tuple .
locs = tuple(random.sample(qubits, n_qubits))
Line 199: Same as above, qubits is a tuple.
locs = tuple(random.sample(qubits, n_qubits))
Line 253: qubits is a list.
this_term_qubits = random.sample(qubits, term_length)
Line 255: paulis is a list.
[random.sample(paulis,1)[0] for _ in range(term_length)]
Please let me know if this fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thankyou!