Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct some description of annotations and spelling of class name #470

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Noba1anc3
Copy link

@Noba1anc3 Noba1anc3 commented Mar 19, 2022

codes

layers/loss.py : change class name SamplingProbablityCorrection to SamplingProbabilityCorrection

layers/loss_test.py : change class name SamplingProbablityCorrection to SamplingProbabilityCorrection for correct reference after the class name has been changed

tasks/retrieval.py : change class name SamplingProbablityCorrection to SamplingProbabilityCorrection for correct reference after the class name has been changed

markdown

CHANGELOG.md : change SamplingProbablityCorrection to SamplingProbabilityCorrection

annotations

tasks/retrieval.py : maybe it is a more precise description of candidates_embeddings that changes candidate_embeddings: [num_queries, embedding_dim] to candidate_embeddings: [num_candidates, embedding_dim] in the description of call function in Retrieval Class

layers/feature_interaction/dot_interaction.py : del redundant annotation word self in the description of DotInteraction Class

@Noba1anc3 Noba1anc3 changed the title change queries to candidates correct some code annotations within dot_interaction and retrieval task Mar 21, 2022
@Noba1anc3 Noba1anc3 changed the title correct some code annotations within dot_interaction and retrieval task correct some description of annotations and spelling of class name Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant