Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gpu docker file #541

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Update gpu docker file #541

merged 1 commit into from
Aug 4, 2017

Conversation

mhamilton723
Copy link
Contributor

The Gpu Docker does not build on master (#540) for several reasons

  1. Tensorflow defaults to cudadnn_6.0
  2. The issue raised and solved in
    bazel GPU build error with fatal error: external/nccl_archive/src/nccl.h: No such file or directory #327 (comment)

This PR solves these two issues and the resulting docker image builds and passes all

@tensorflow-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@mhamilton723
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot
Copy link

CLAs look good, thanks!

@mhamilton723
Copy link
Contributor Author

mhamilton723 commented Aug 4, 2017

What are the thoughts of the tf serving team? @chrisolston Is there a specific process for requesting code review?

@kirilg
Copy link
Contributor

kirilg commented Aug 4, 2017

Thanks for the contribution Mark!

@kirilg kirilg merged commit 293d8d8 into tensorflow:master Aug 4, 2017
simon-mo pushed a commit to simon-mo/serving that referenced this pull request Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants