Skip to content

Commit 242c0b0

Browse files
authored
Chore: fix runaway test issue (#6460)
## Motivation for features / changes In #6458 I fixed a couple of a tests which should have been failing but were sporadically passing. In this PR I believe I have fixed the underlying cause of the flakiness. Thanks #6266 for pointing the way. This broke nightly last night https://github.com/tensorflow/tensorboard/actions/runs/5388986210/jobs/9782358616
1 parent f34562b commit 242c0b0

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

tensorboard/webapp/core/views/layout_test.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,6 @@ describe('layout test', () => {
8686
dispatchedActions.push(action);
8787
});
8888
store.overrideSelector(getSideBarWidthInPercent, 10);
89-
// When the runs table is full screen the width is overridden to 100%.
90-
store.overrideSelector(getRunsTableFullScreen, false);
9189
});
9290

9391
afterEach(() => {

tensorboard/webapp/metrics/views/metrics_container_test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,10 @@ describe('metrics view', () => {
4040
store = TestBed.inject<Store<State>>(Store) as MockStore<State>;
4141
});
4242

43+
afterEach(() => {
44+
store.resetSelectors();
45+
});
46+
4347
it('renders', () => {
4448
store.overrideSelector(getEnableHparamsInTimeSeries, false);
4549
const fixture = TestBed.createComponent(MetricsDashboardContainer);

tensorboard/webapp/runs/views/runs_table/runs_data_table.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,15 +89,15 @@ export class RunsDataTable {
8989
}
9090

9191
getRunIds() {
92-
return (this.data || []).map((row) => row.id);
92+
return this.data.map((row) => row.id);
9393
}
9494

9595
allRowsSelected() {
96-
return (this.data || []).every((row) => row['selected']);
96+
return this.data.every((row) => row['selected']);
9797
}
9898

9999
someRowsSelected() {
100-
return (this.data || []).some((row) => row['selected']);
100+
return this.data.some((row) => row['selected']);
101101
}
102102

103103
onFilterKeyUp(event: KeyboardEvent) {

0 commit comments

Comments
 (0)