Fix flaky feature flag test. #6266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
commented
Mar 23, 2023
| flags: ['showFlags'], | ||
| }) | ||
| this.showFeatureFlags$ | ||
| .pipe(takeUntil(this.ngUnsubscribe)) |
Contributor
Author
There was a problem hiding this comment.
The diff for ngOnInit may look bigger than it is.
This line is new.
| .pipe(takeUntil(this.ngUnsubscribe)) | ||
| .subscribe((showFeatureFlags: boolean) => { | ||
| if (showFeatureFlags) { | ||
| this.featureFlagsDialog = this.dialog.open( |
Contributor
Author
There was a problem hiding this comment.
This statement has changed
| }); | ||
| this.featureFlagsDialog | ||
| .afterClosed() | ||
| .pipe(takeUntil(this.ngUnsubscribe)) |
Contributor
Author
There was a problem hiding this comment.
This line is new. Otherwise everything else in ngOnInit should be the same
rileyajones
approved these changes
Mar 23, 2023
bmd3k
added a commit
to bmd3k/tensorboard
that referenced
this pull request
Mar 25, 2023
bmd3k
added a commit
that referenced
this pull request
Mar 25, 2023
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
Feature flag tests have been flaky since the Angular 13/14 upgrade. The problematic change was actually tensorflow#6056, where we started using resetSelectors everywhere. There is one test where a dialog with FeatureFlagDialogContainer is opened. Sometimes FeatureFlagDialogContainer would not complete initialization until after the test was torn down and the selectors reset, meaning NgRx selector calls would fail since state is undefined at that point. To workaround this problem, I allow FeatureFlagDialogContainer to be replaced by a simpler TestableFeatureFlagDialogComponent that has no dependencies on NgRx. This is a strategy we've used elsewhere in the code: https://github.com/tensorflow/tensorboard/blob/dca18190a18ac151437bb6fcd128bc49af617ae5/tensorboard/webapp/metrics/views/card_renderer/scalar_card_container.ts#L206 While I was in this code, I did some other cleanup: * Stop running the feature flag view tests twice. Only run them as part of the feature flag test suite. * When FeatureFlagModalTriggerContainer is destroyed, unsubscribe from some subjects created in ngOnInit. * Remove some unnecessary setup from FeatureFlagModalTriggerContainer tests. Alternative solution: * I thought I could solve the problem by calling dialog.close() in the tests but observed that closing the dialog is not enough to prevent the child component from instantiating after the test.
yatbear
pushed a commit
to yatbear/tensorboard
that referenced
this pull request
Mar 27, 2023
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
Feature flag tests have been flaky since the Angular 13/14 upgrade. The problematic change was actually tensorflow#6056, where we started using resetSelectors everywhere. There is one test where a dialog with FeatureFlagDialogContainer is opened. Sometimes FeatureFlagDialogContainer would not complete initialization until after the test was torn down and the selectors reset, meaning NgRx selector calls would fail since state is undefined at that point. To workaround this problem, I allow FeatureFlagDialogContainer to be replaced by a simpler TestableFeatureFlagDialogComponent that has no dependencies on NgRx. This is a strategy we've used elsewhere in the code: https://github.com/tensorflow/tensorboard/blob/dca18190a18ac151437bb6fcd128bc49af617ae5/tensorboard/webapp/metrics/views/card_renderer/scalar_card_container.ts#L206 While I was in this code, I did some other cleanup: * Stop running the feature flag view tests twice. Only run them as part of the feature flag test suite. * When FeatureFlagModalTriggerContainer is destroyed, unsubscribe from some subjects created in ngOnInit. * Remove some unnecessary setup from FeatureFlagModalTriggerContainer tests. Alternative solution: * I thought I could solve the problem by calling dialog.close() in the tests but observed that closing the dialog is not enough to prevent the child component from instantiating after the test.
dna2github
pushed a commit
to dna2fork/tensorboard
that referenced
this pull request
May 1, 2023
rileyajones
added a commit
that referenced
this pull request
Jun 27, 2023
## Motivation for features / changes In #6458 I fixed a couple of a tests which should have been failing but were sporadically passing. In this PR I believe I have fixed the underlying cause of the flakiness. Thanks #6266 for pointing the way. This broke nightly last night https://github.com/tensorflow/tensorboard/actions/runs/5388986210/jobs/9782358616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature flag tests have been flaky since the Angular 13/14 upgrade. The problematic change was actually #6056, where we started using resetSelectors everywhere.
There is one test where a dialog with FeatureFlagDialogContainer is opened. Sometimes FeatureFlagDialogContainer would not complete initialization until after the test was torn down and the selectors reset, meaning NgRx selector calls would fail since state is undefined at that point.
To workaround this problem, I allow FeatureFlagDialogContainer to be replaced by a simpler TestableFeatureFlagDialogComponent that has no dependencies on NgRx. This is a strategy we've used elsewhere in the code:
tensorboard/tensorboard/webapp/metrics/views/card_renderer/scalar_card_container.ts
Line 206 in dca1819
While I was in this code, I did some other cleanup:
Alternative solution: