Skip to content

Commit ac3f8d9

Browse files
committed
Fix horizontal resizer in debugger (#1704)
While refactoring the dashboard layout, we inadvertently broke the horizontal resizing capability. The resizer was clipped and was bound by the TB global max/min-width limit on the sidebar width.
1 parent a21f5b3 commit ac3f8d9

File tree

2 files changed

+19
-9
lines changed

2 files changed

+19
-9
lines changed

tensorboard/components/tf_dashboard_common/tf-dashboard-layout.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@
4040
}
4141

4242
#sidebar {
43-
flex: 0 0 25%;
43+
flex: 0 0 var(--tf-dashboard-layout-sidebar-basis, 25%);
4444
height: 100%;
45-
max-width: 350px;
46-
min-width: 270px;
45+
max-width: var(--tf-dashboard-layout-sidebar-max-width, 350px);
46+
min-width: var(--tf-dashboard-layout-sidebar-min-width, 270px);
4747
overflow-y: auto;
4848
text-overflow: ellipsis;
4949
}

tensorboard/plugins/debugger/tf_debugger_dashboard/tf-debugger-dashboard.html

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,11 @@
202202
width: 40vw;
203203
margin-left: 30vw;
204204
}
205+
tf-dashboard-layout {
206+
--tf-dashboard-layout-sidebar-basis: auto;
207+
--tf-dashboard-layout-sidebar-max-width: unset;
208+
--tf-dashboard-layout-sidebar-min-width: unset;
209+
}
205210
.debugger-section-title {
206211
font-size: 110%;
207212
font-weight: bold;
@@ -271,13 +276,17 @@
271276
margin: 80px auto 0 auto;
272277
}
273278
.sidebar {
274-
position: relative;
275279
height: 100%;
280+
overflow-x: visible;
281+
position: relative;
276282
}
277283
.center {
278284
position: relative;
279285
height: 100%;
280286
}
287+
tf-debugger-resizer {
288+
right: -10px;
289+
}
281290
#center-content {
282291
position: absolute;
283292
right: 0;
@@ -301,15 +310,16 @@
301310
vertical-align: middle;
302311
}
303312
.node-entries {
304-
position: relative;
313+
box-shadow: 3px 3px #ddd;
314+
box-sizing: border-box;
305315
height: 80%;
306-
width: 100%;
307-
vertical-align: top;
308316
overflow: auto;
309-
padding-top: 3px;
310317
padding-left: 3px;
311318
padding-right: 3px;
312-
box-shadow: 3px 3px #ddd;
319+
padding-top: 3px;
320+
position: relative;
321+
vertical-align: top;
322+
width: 100%;
313323
}
314324
.source-code-view-div {
315325
position: relative;

0 commit comments

Comments
 (0)