Skip to content

Conversation

@stephanwlee
Copy link
Contributor

@stephanwlee stephanwlee commented Dec 18, 2018

While refactoring the dashboard layout, we inadvertently broke the
horizontal resizing capability. The resizer was clipped and was bound
by the TB global max/min-width limit on the sidebar width.

Before

image

  • Note that Show code is clipped due to the max-width on the container.

After

image

While refactoring the dashboard layout, we inadvertantly broke the
horizontal resizing capability. The resizer was clippped and was bound
by the TB global max/min-width limit on the sidebar width.
@stephanwlee stephanwlee requested a review from nfelt January 2, 2019 23:27
@stephanwlee stephanwlee merged commit 1b7f353 into tensorflow:master Jan 3, 2019
@stephanwlee stephanwlee deleted the layout2 branch January 3, 2019 00:17
stephanwlee added a commit to stephanwlee/tensorboard that referenced this pull request Jan 3, 2019
While refactoring the dashboard layout, we inadvertently broke the
horizontal resizing capability. The resizer was clipped and was bound
by the TB global max/min-width limit on the sidebar width.
stephanwlee added a commit that referenced this pull request Jan 3, 2019
While refactoring the dashboard layout, we inadvertently broke the
horizontal resizing capability. The resizer was clipped and was bound
by the TB global max/min-width limit on the sidebar width.
@caisq
Copy link
Contributor

caisq commented Feb 2, 2019

Just noticed this. Thanks a lot, @stephanwlee !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants