Fix ES6 module resolution and polish build tooling #1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a regression that might have been introduced by a TypeScript upgrade a few months ago, where Facets wasn't able to compile, possibly due to tsc.js no longer adding .js to ES6 imports. The solution was to set module resolution to NODE in the Closure Compiler. The Polymer dep was upstreamed for more completeness for Facets. This change also ensures that the development web server, when we `bazel run` a `tf_web_library` or `tensorboard_html_binary` rule, will display sources in the correct order we had originally, before Bazel changed from set() to depset().
Contributor
|
LGTM |
Contributor
Author
|
LGTM counts as approval in my book. We'll be adding you to the collaborators list soon enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a regression that might have been introduced by a TypeScript
upgrade a few months ago, where Facets wasn't able to compile, possibly due to
tsc.js no longer adding .js to ES6 imports. The solution was to set module
resolution to NODE in the Closure Compiler. The Polymer dep was upstreamed for
more completeness for Facets.
This change also ensures that the development web server, when we
bazel runatf_web_libraryortensorboard_html_binaryrule, will display sources in thecorrect order we had originally, before Bazel changed from set() to depset().
r/cc: @jameswex