Perf: optimized tooltip redraw #1355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Changing vz-line-chart has been known to be dangerous in the past, due to certain internal things that depend on it, which we're not able to test. Do you think we might want to copy this over to a vz-line-chart2 directory? |
Contributor
Author
|
Got it. Just for my information, what specifically has happened in the past when changing vz-line-chart especially when it is a simple implementation change instead of API or behavioral change? Thanks! |
Contributor
Author
|
Done with the fork. Thanks for the suggestion :D |
jart
approved these changes
Aug 20, 2018
Contributor
jart
left a comment
jart
left a comment
There was a problem hiding this comment.
I suggest this be squashed down to two commits:
Copy vz_line_chart to vz_line_chart2Improve tooltip redraw performance
Then force push, and use GitHub Rebase Merge.
Note that this changes vz-line-chart2, not vz-line-chart. In this change, it: - update tooltip instead of complete redraw. Tooltip, previously, threw away all items and created all rows anew on mouse move. It poorly scaled with number of rows (runs). Instead, we now use d3 way of creating and updating each row on mouse move. - reorganizes how tooltip is draw - optimizes calculation of finding nearest data point from dataset. Previously, it computed y-value for all data points (MxN) where M ~ 1000 and 1 <= N <= ~20. It calculates nearest point only based on x-value. - Wrap tooltip update around RAF. With large N and M, an update took long enough to miss one animation frame. Instead of doing an update right away, if we missed next animation frame, schedule an update onto the next animation frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this changes vz-line-chart.
In this change, it:
away all items and created all rows anew on mouse move. It poorly
scaled with number of rows (runs). Instead, we now use d3 way of
creating and updating each row on mouse move.
Previously, it computed y-value for all data points (MxN) where
M ~ 1000 and 1 <= N <= ~20. It calculates nearest point only based on
x-value.
long enough to miss one animation frame. Instead of doing an update
right away, if we missed next animation frame, schedule an update
onto the next animation frame.