BUG: Fixed chart rendering issues #1375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Experiments did not have the right unique ID for fetching because, even in the multi experiment mode, `this` was pointing at the wrong instance. - Fixed the issue where chart did not create when toggling visibility with the tag header - Fixed the issue where data-loader fetched incomplete selection in the beginning due to the timing issue. Data-selection was bootstrapping from the storage and it changes the output rapidly. Without debounce, data-loader starts to fetch and it causes timing issue. - Set dataSelection only when a dashboard requires it.
nfelt
approved these changes
Aug 23, 2018
stephanwlee
added a commit
to stephanwlee/tensorboard
that referenced
this pull request
Oct 18, 2018
PR tensorflow#1375 conflated the ideas and caused explicitly resetted the domain on any data fetch (even if it is already loaded). This will cause some other "regression" (typing on tag filter then deleting it quickly causes chart to not draw any axis) but it should be addressed in other PRs.
stephanwlee
added a commit
that referenced
this pull request
Oct 18, 2018
PR #1375 conflated the ideas and caused explicitly resetted the domain on any data fetch (even if it is already loaded). This will cause some other "regression" (typing on tag filter then deleting it quickly causes chart to not draw any axis) but it should be addressed later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
even in the multi experiment mode,
thiswas pointing at the wronginstance.
with the tag header
beginning due to the timing issue. Data-selection was bootstrapping
from the storage and it changes the output rapidly. Without debounce,
data-loader starts to fetch and it causes timing issue.