Skip to content

Revert category pane behavior to 1.10 #1455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfelt merged 1 commit into from
Sep 22, 2018
Merged

Revert category pane behavior to 1.10 #1455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions tensorboard/components/tf_categorization_utils/categorizationUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,16 @@ export function categorizeTags(
runToTag: RunToTag,
selectedRuns: string[],
query?: string): TagCategory[] {
runToTag = _.pick(runToTag, selectedRuns);
const tags = tf_backend.getTags(runToTag);
const categories = categorize(tags, query);
const tagToRuns = createTagToRuns(runToTag);
const tagToRuns = createTagToRuns(_.pick(runToTag, selectedRuns));

return categories.map(({name, metadata, items}) => ({
name,
metadata,
items: items.map(tag => ({
tag,
runs: tagToRuns.get(tag).slice(),
runs: (tagToRuns.get(tag) || []).slice(),
})),
}));
}
Expand Down
6 changes: 2 additions & 4 deletions tensorboard/plugins/scalar/tf_scalar_dashboard/tf-scalar-dashboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ <h3>No scalar data was found.</h3>
const PLUGIN_NAME = 'scalars';
const USE_DATA_SELECTOR = tf_globals.getEnableDataSelector();
const SelectionType = tf_data_selector.Type;
const NUM_DEFAULT_OPENED_PANE = 2;
const NUM_DEFAULT_OPENED_PANE = 3;

Polymer({
is: 'tf-scalar-dashboard',
Expand Down Expand Up @@ -377,9 +377,7 @@ <h3>No scalar data was found.</h3>
query = tagRegex;
selectedRuns = runs.map(({name}) => name);
}
const runToTag = _.mapValues(
_.pick(runToTagInfo, selectedRuns),
x => Object.keys(x));
const runToTag = _.mapValues(runToTagInfo, x => Object.keys(x));
categories = tf_categorization_utils.categorizeTags(
runToTag, selectedRuns, query);
categories.forEach(category => {
Expand Down