Skip to content

Fix --purge_ophaned_data flag to allow passing false #1511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfelt merged 1 commit into from
Oct 10, 2018
Merged

Fix --purge_ophaned_data flag to allow passing false #1511

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tensorboard/plugins/core/core_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,9 @@ def define_flags(self, parser):
parser.add_argument(
'--purge_orphaned_data',
metavar='BOOL',
type=bool,
nargs=1,
# Custom str-to-bool converter since regular bool() doesn't work.
type=lambda v: {'true': True, 'false': False}.get(v.lower(), v),
choices=[True, False],
default=True,
help='''\
Whether to purge data that may have been orphaned due to TensorBoard
Expand Down