-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Made audio, scalar, graph demo work again #1512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be unused?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this is new functionality, it seems better to me to just require passing in an actual URLSearchParams object, rather than sticking with the custom QueryParams type. You can construct URLSearchParams directly from a map, so most callsites can be updated by just wrapping a new URLSearchParams() around the argument. I don't actually know that we have any callsites that use repeated/list-valued parameters, but if so, they can pass in a list of pairs instead or build up the instance via append().
This way the code in e.g. the audio plugin can be much simpler since there's no need to create URLSearchParams, convert it into QueryParams, and then reconvert back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: s/correcrt/correct/ here and below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extension is already ignored unless we're in demo mode, so simpler to just pass '.wav' all the time and let Router figure it out.
|
Ugh, it looks like, although you can pass object to the constructor of URLSearchParams and get the right instance, it is defined to take string or another instance of URLSearchParams (https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams/URLSearchParams#Parameters). Either that or someone is not updated correctly and TypeScript disallows passing a object :( |
|
@stephanwlee: This appears to break the Before this commit, running and then navigating to http://localhost:6006/test/ yielded a fully Network traffic indicates that the frontend is hitting Git bisect says:
Could you please investigate? |
|
From what I can tell, it looked like the result of the default router’s
The |
PR tensorflow#1512 introduced a bug where it formed a complete path without using existing pathname. Previously without forming the complete path, it was treated as a relative path from current window.location.pathname.
PR #1512 introduced a bug where it formed a complete path without using existing pathname. Previously without forming the complete path, it was treated as a relative path from current window.location.pathname. We decided to revert back to the old behavior without using `new URL` which was not providing a clear benefit.
PR tensorflow#1512 introduced a bug where it formed a complete path without using existing pathname. Previously without forming the complete path, it was treated as a relative path from current window.location.pathname. We decided to revert back to the old behavior without using `new URL` which was not providing a clear benefit.
PR #1512 introduced a bug where it formed a complete path without using existing pathname. Previously without forming the complete path, it was treated as a relative path from current window.location.pathname. We decided to revert back to the old behavior without using `new URL` which was not providing a clear benefit.
Major changes:
Minor changes are:
a. audio_dashboard had missing
</template>only causing demo to not workb. graph_dashboard was missing an import statement for
tf_storage