Fix debugger plugin source code viewer "_.contains not found" error #1550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfelt
approved these changes
Oct 25, 2018
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
Thanks for the fix!
Actually, _.contains() was in lodash as an alias to _.includes prior to lodash v4, so it looks like this was another area where we got bitten by upgrading :(
Maybe we should proactively check against the rest of the changelog, there might be more stuff we're missing... https://github.com/lodash/lodash/wiki/Changelog#v400
Contributor
Author
|
Thanks for the quick merge! |
stephanwlee
pushed a commit
to stephanwlee/tensorboard
that referenced
this pull request
Dec 13, 2018
stephanwlee
pushed a commit
that referenced
this pull request
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
The source code view in the debugger plugin isn't working. The code tries to call
_.contains, which is a method in Underscore, but not Lodash, which is the actual library used. Changing the call to_.includesfixes things.