FIX: chart correctly shows series when toggled #1567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repro steps: 1. Display two series 2. Toggle off one series (using run selector) 3. Create a new chart instance by say toggle log scale 4. Toggle on the series that got turned off 5. ?? where is the second series? This bug happened at least since 1.9 and is not a recent regression.
nfelt
approved these changes
Oct 31, 2018
Contributor
nfelt
left a comment
nfelt
left a comment
There was a problem hiding this comment.
Thanks for catching the bug!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repro steps:
This bug happened at least since TB==1.7 and is not a recent regression.