Add colab implementation of WitWidget #1745
Conversation
|
@tolga-b Please take a look, thanks! |
|
Thanks James, it looks great. You may want to add a direct link to colab in the readme as we discussed: https://colab.sandbox.google.com/github/jameswex/tensorboard/blob/colab/tensorboard/plugins/interactive_inference/WIT_in_colab.ipynb. Format is github/[repo-link]/blob/[branch-name]/[path-within-repo-to-file]. |
| def infer_examples(): | ||
| WitWidget.widget.infer() | ||
| output.register_callback('notebook.InferExamples', infer_examples) | ||
|
|
There was a problem hiding this comment.
I think its suggested to have two spaces between module functions.
|
thanks tolga, added that direct link in the spot at the bottom and also another spot near the top of the readme where i mention colab. also updated widget to be able to handle multiple witwidgets in a single colab and tested it with two witwidgets. |
stephanwlee
left a comment
stephanwlee
left a comment
There was a problem hiding this comment.
Everything else look good
|
|
||
|
|
||
| # HTML/javascript for the WIT frontend. | ||
| WIT_HTML = """ |
There was a problem hiding this comment.
It would be wonderful if this is created/went through compilation/Vulcanization and read as a string. Would it be possible?
There was a problem hiding this comment.
I think it might be possible. I have a what-if tool tutorial I'm giving at a conference later this month and was hoping to have this mode up and running for it, and our team is just starting a two-week sprint on other ideas so I don't have much time to investigate right now.
Is it possible to commit this with the code in-line and create an issue to track moving it to a string read from a compiled html/js file in the future?
tolga-b
left a comment
tolga-b
left a comment
There was a problem hiding this comment.
Thanks James, everything looks good to me.
3 participants
Adds colab implementation of WitWidget to enable use of What-If Tool directly in colab notebooks. This implementation differs by necessity from the Jupyter notebook widget.
Added Colab implemenation of WitWidget, which uses the colab-recommended way of passing information from python to JS and passing information from JS to python.
Added example colab notebook showing its use.
Run the colab notebook that is part of the PR and verify all What-If Tool features work correctly.
N/A