server: amend #1851’s port-crawling implementation #1858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin-branch: port-search-revisions
wchargin-branch: port-search-revisions
wchargin-branch: port-search-revisions
wchargin-branch: port-search-revisions
nfelt
approved these changes
Feb 16, 2019
| ) | ||
| max_attempts = 10 if should_scan else 1 | ||
| base_port = min(base_port + max_attempts, 65536) - max_attempts | ||
| base_port = min(base_port + max_attempts, 0x10000) - max_attempts |
Contributor
There was a problem hiding this comment.
Re-reading this logic, is this line really necessary? It can't actually be reached in the current code, it would only happen if we set the default base_port to a number within 10 of 65536.
Contributor
Author
There was a problem hiding this comment.
That’s correct. I should add to the test plan that I did in fact test
this by changing the core_plugin.DEFAULT_PORT to 65534 and observing
that it binds to 65526 instead.
(Arguably it would be nicer to count down in such a case, but for code
that is never executed I have a limited budget for aesthetics.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In response to a helpful post-commit review from @nfelt.
Test Plan:
Most of the changes are non-functional. The wildcard address resolution
logic did change, but we don’t expect the behavior to. The test plan
from #1851 suffices, plus explicitly binding
--hostto each oflocalhost,"$(hostname)","$(hostname -s)",127.0.0.1, and::to verify that each works.
wchargin-branch: port-search-revisions