-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Enable the hparams plugin #1882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@manivaradarajan @GalOshri Erez. |
wchargin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely! Can confirm that running the demo script to generate fresh data
causes the hparams plugin to appear as active, and that the main
features that I know about appear to work as intended. Nice work.
Please change “Enabled” to “Enable” in the pull request title, to follow
standard open-source style (which also happens to be Google style).
Please fill in the appropriate parts of the pull request description
template. In particular, a test plan is required, and at least a
screenshot would be appreciated.
Some usability observations:
-
When the dashboard is selected when it is inactive, the backend
400s. Instead, it should show a nice “no data” message. -
When the backend 400s, this is shown to the user via an
alert,
which is pretty intrusive. Instead, we might want to show a
paper-dialog—or just display appropriate text in the “no data”
message.
Are these being tracked anywhere?
One change requested inline, then you should be good to go as long as
the above issues are in some known tracker (preferably public).
erzel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added tracking of the bugs above to our internal tool since this is where the other bugs are currently logged. We can export all of them as github issues later.
|
Thanks @wchargin! PTAL. |
|
Thanks! |
Motivation for features / changes: Enable the HParams plugin in Tensorboard. HParams allows visualizations of experiments ran for hyperparameter tuning.
Screenshots of UI changes

Detailed steps to verify changes work correctly (as executed by you)
and (briefly) verified manually that the plugins works as expected.