scalar: use ObjectURL for SVG link for durability #1979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data uri in the link for download has given us some trouble with encoding and length limitations. We want to use the ObjectURL like PR#1610 that is more durable to aforementioned limitations.
wchargin
reviewed
Mar 7, 2019
tensorboard/plugins/scalar/tf_scalar_dashboard/tf-scalar-card.html
Outdated
Show resolved
Hide resolved
wchargin
approved these changes
Mar 8, 2019
tensorboard/plugins/scalar/tf_scalar_dashboard/tf-scalar-card.html
Outdated
Show resolved
Hide resolved
wchargin
added a commit
that referenced
this pull request
Mar 12, 2019
Summary: This reverts commit e46bab9. A Google-internal check objects to that PR on the grounds that object URLs can induce XSS vulnerabilities. Googlers, see <http://b/128425516>. Test Plan: Downloading the chart still works, in both Chrome 72 and Firefox 60.5.1esr. wchargin-branch: revert-1979
wchargin
added a commit
that referenced
this pull request
Mar 12, 2019
…2002) Summary: This reverts commit e46bab9. A Google-internal check objects to that PR on the grounds that object URLs can induce XSS vulnerabilities. Googlers, see <http://b/128425516>. Test Plan: Downloading the chart still works, in both Chrome 72 and Firefox 60.5.1esr. wchargin-branch: revert-1979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data uri in the link for download has given us some trouble with
encoding and length limitations. We want to use the ObjectURL like
PR #1610 that is more durable to aforementioned limitations.
Tested this on Chrome 72 & 74, Firefox 65, and Safari.