Skip to content

Conversation

@nfelt
Copy link
Contributor

@nfelt nfelt commented Apr 25, 2019

The --version flag introduced in #2097 unfortunately conflicts with a non-optional Google-internal --version flag. By renaming it --version_tb we avoid the conflict, while still allowing the flag to be used like tensorboard --version because argparse auto-expands unambiguous flag prefixes.

@nfelt nfelt requested a review from wchargin April 25, 2019 19:06
Copy link
Contributor

@wchargin wchargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy.

@nfelt nfelt merged commit 2dc64f7 into tensorflow:master Apr 25, 2019
@nfelt nfelt deleted the version-flag-rename branch April 25, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants