-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ci: change VM base from Trusty to Xenial #2293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary: Out of curiosity, to see whether there are meaningful performance differences. [Travis docs][1] indicate that Trusty is still the default, but Xenial has newer versions of some dependencies (Git, OpenJDK) and a streamlined apt configuration. Also, while the Trusty build environment is still supported, Trusty itself is (recently) past end-of-life, while Xenial support extends until 2021. Test Plan: CI suffices. [1]: https://docs.travis-ci.com/user/reference/overview/ wchargin-branch: travis-xenial
|
A preliminary run on my fork indicates that this likely isn’t faster; Preliminary run: |
|
Comparing before this commit and after it:
It seems a bit slower across the board, by about 20 seconds per job |
|
Reopening for consistency with TensorFlow, whose CI now runs on 16.04. |
wchargin-source: da6ba8981923453b5b41fdd014b9baf646ed4f60 wchargin-branch: travis-xenial
wchargin-source: da6ba8981923453b5b41fdd014b9baf646ed4f60 wchargin-branch: travis-xenial
wchargin-source: 48a2c2d9623d1ab0d5d4e39f11c11331c65c5a4b wchargin-branch: travis-xenial
wchargin-source: 334f5d375fc7fb138bf9a729c8b4d57c18bbbe70 wchargin-branch: travis-xenial
wchargin-source: bb3ff71428b480db36c58e23b697aac9f0c49c4f wchargin-branch: travis-xenial
|
Persistent issue when running |
Summary:
Reopening for consistency with TensorFlow, whose CI now runs on 16.04.
Travis docs indicate that Trusty is still the default as of
2019-07-31, but Xenial has newer versions of some dependencies (Git,
OpenJDK) and a streamlined apt configuration. Also, while the Trusty
build environment is still supported, Trusty itself is (recently) past
end-of-life, while Xenial support extends until 2021.
Change to
build_pip_package.shis required to avoid anEROFSin theTravis build.
Test Plan:
CI suffices.
wchargin-branch: travis-xenial