Skip to content

Conversation

@wchargin
Copy link
Contributor

@wchargin wchargin commented May 30, 2019

Summary:
Reopening for consistency with TensorFlow, whose CI now runs on 16.04.

Travis docs indicate that Trusty is still the default as of
2019-07-31, but Xenial has newer versions of some dependencies (Git,
OpenJDK) and a streamlined apt configuration. Also, while the Trusty
build environment is still supported, Trusty itself is (recently) past
end-of-life, while Xenial support extends until 2021.

Change to build_pip_package.sh is required to avoid an EROFS in the
Travis build.

Test Plan:
CI suffices.

wchargin-branch: travis-xenial

Summary:
Out of curiosity, to see whether there are meaningful performance
differences. [Travis docs][1] indicate that Trusty is still the default,
but Xenial has newer versions of some dependencies (Git, OpenJDK) and a
streamlined apt configuration. Also, while the Trusty build environment
is still supported, Trusty itself is (recently) past end-of-life, while
Xenial support extends until 2021.

Test Plan:
CI suffices.

[1]: https://docs.travis-ci.com/user/reference/overview/

wchargin-branch: travis-xenial
@wchargin
Copy link
Contributor Author

A preliminary run on my fork indicates that this likely isn’t faster;
but I’m testing it on the main repository for a fair comparison to rule
out any differences between Travis.org and Travis.com.

Preliminary run:
https://travis-ci.org/wchargin/tensorboard/builds/539076896

wchargin-branch: travis-xenial
@wchargin
Copy link
Contributor Author

Comparing before this commit and after it:

It seems a bit slower across the board, by about 20 seconds per job
(1m50s slower overall). I’ll close this; feel free to reopen if you
think that we should merge it for reasons other than performance.

@wchargin wchargin closed this May 30, 2019
@wchargin wchargin deleted the wchargin-travis-xenial branch June 3, 2019 20:53
@wchargin wchargin restored the wchargin-travis-xenial branch July 30, 2019 23:37
@wchargin wchargin reopened this Jul 30, 2019
@wchargin
Copy link
Contributor Author

Reopening for consistency with TensorFlow, whose CI now runs on 16.04.

wchargin added 2 commits July 31, 2019 17:46
wchargin-source: da6ba8981923453b5b41fdd014b9baf646ed4f60
wchargin-branch: travis-xenial
wchargin-source: da6ba8981923453b5b41fdd014b9baf646ed4f60
wchargin-branch: travis-xenial
wchargin added 3 commits July 31, 2019 17:56
wchargin-source: 48a2c2d9623d1ab0d5d4e39f11c11331c65c5a4b
wchargin-branch: travis-xenial
wchargin-source: 334f5d375fc7fb138bf9a729c8b4d57c18bbbe70
wchargin-branch: travis-xenial
wchargin-source: bb3ff71428b480db36c58e23b697aac9f0c49c4f
wchargin-branch: travis-xenial
@wchargin
Copy link
Contributor Author

wchargin commented Aug 1, 2019

Persistent issue when running //tensorboard/plugins/example:smoke_test
under Python 3. Looks like perhaps the HTTP API isn’t responding to any
requests. Postponing work on this for now.

@wchargin
Copy link
Contributor Author

Resolved by #3070, c/o @caisq.

@wchargin wchargin closed this Dec 26, 2019
@wchargin wchargin deleted the wchargin-travis-xenial branch December 26, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants