Fix py3 issue with AI Platform models #2311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tolga-b please review |
tolga-b
approved these changes
Jun 5, 2019
Contributor
|
This roughly looks like something that six probably addresses. Since I lack profound knowledge, I assigned the PR to @nfelt for review. |
Contributor
|
I wonder if six.ensure_text or six.ensure_str is the way to go.
|
Contributor
Author
|
switched to six.ensure_str - thanks |
stephanwlee
requested changes
Jun 6, 2019
| from IPython import display | ||
| from google.protobuf import json_format | ||
| from numbers import Number | ||
| from six import ensure_str |
Contributor
There was a problem hiding this comment.
You may want to add six dependency on the BUILD file.
stephanwlee
approved these changes
Jun 6, 2019
|
|
||
| import base64 | ||
| import json | ||
| import googleapiclient.discovery |
Contributor
There was a problem hiding this comment.
Should probably do this as a separate PR but how was this previously working? GAPI isn't part of our dependency declaration and I believe we didn't do anything special to install it.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WIT, models that accept JSON as input were failing in python 3 notebooks due to how bytes_list protos are handled.
Added wrapper method for handling of objects that in py3 are bytes but in py2 are string (such as bytes_list handling from tf Example proto) to ensure they encoded as strings for use in WIT.
N/A
Ran py3 colab notebook with the offending model with local pip package built with this change and verified that it now works correctly in WIT.
Ran other colab notebooks to verify it didn't cause regressions.