Skip to content

Confirm that the connection to tensorboard works or change to localhost #2371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nfelt merged 7 commits into from
Mar 13, 2020
Merged

Confirm that the connection to tensorboard works or change to localhost #2371

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9ce0f8b
used fully qualified domain name instead of just hostname
mm3509 Feb 25, 2020
8bdd196
tested connection to server IP, defaulted to localhost, and included …
mm3509 Feb 25, 2020
5defff3
ran Black reformatting
mm3509 Feb 25, 2020
c01fe3b
moved display_host field to WerkzeugServer object
mm3509 Feb 26, 2020
3f99276
cached entire url, per nfelt's comment
mm3509 Mar 11, 2020
f3bbb87
removed blank line
mm3509 Mar 11, 2020
2b6067a
removed trailing whitespace
mm3509 Mar 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions tensorboard/program.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ def __init__(self, wsgi_app, flags):
host = "localhost"

self._host = host
self._url = None # Will be set by get_url() below

self._fix_werkzeug_logging()
try:
Expand Down Expand Up @@ -727,20 +728,30 @@ def handle_error(self, request, client_address):
logger.error("HTTP serving error", exc_info=exc_info)

def get_url(self):
if self._auto_wildcard:
display_host = socket.gethostname()
else:
host = self._host
display_host = (
"[%s]" % host
if ":" in host and not host.startswith("[")
else host
if not self._url:
if self._auto_wildcard:
display_host = socket.getfqdn()
# Confirm that the connection is open, otherwise change to `localhost`
try:
socket.create_connection(
(display_host, self.server_port), timeout=1
)
except socket.error as e:
display_host = "localhost"

else:
host = self._host
display_host = (
"[%s]" % host
if ":" in host and not host.startswith("[")
else host
)
self._url = "http://%s:%d%s/" % (
display_host,
self.server_port,
self._flags.path_prefix.rstrip("/"),
)
return "http://%s:%d%s/" % (
display_host,
self.server_port,
self._flags.path_prefix.rstrip("/"),
)
return self._url

def print_serving_message(self):
if self._flags.host is None and not self._flags.bind_all:
Expand Down