Skip to content

Handle large mutliclass better in WIT #2385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jameswex merged 2 commits into from
Jun 27, 2019
Merged

Handle large mutliclass better in WIT #2385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce72936
fix multiclass
jameswex Jun 25, 2019
1b1455b
review comments
jameswex Jun 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 39 additions & 4 deletions ...tive_inference/tf_interactive_inference_dashboard/tf-interactive-inference-dashboard.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,6 +1017,10 @@
margin-left: 30px;
}

.scroll-x {
overflow-x: auto;
}

.perf-table-clickable {
cursor: pointer;
}
Expand Down Expand Up @@ -2081,7 +2085,7 @@ <h2>Show similarity to selected datapoint</h2>
</div>
</div>
<iron-collapse opened="{{featureValueThreshold.opened}}">
<div class="perf-table-entry-expanded flex-row-reverse">
<div class="perf-table-entry-expanded flex-row-reverse scroll-x">
<div>
<template is="dom-if" if="[[shouldShowFeaturePrCharts_(selectedLabelFeature, selectedBreakdownFeature, inferences)]]">
<div class="conf-matrix-holder">
Expand Down Expand Up @@ -2124,7 +2128,7 @@ <h2>Show similarity to selected datapoint</h2>
</div>
</div>
</div>
<div class="perf-table-entry-expanded flex-row-reverse">
<div class="perf-table-entry-expanded flex-row-reverse scroll-x">
<template is="dom-if" if="[[shouldShowOverallPrChart_(selectedLabelFeature, selectedBreakdownFeature, inferences)]]">
<div class="conf-matrix-holder">
<div class="conf-text">Confusion matrix</div>
Expand Down Expand Up @@ -5032,10 +5036,41 @@ <h2>Show similarity to selected datapoint</h2>
*/
addChart: function(chartType, featureName, data){
let chart;
let dataToChart = data;

// If multiclass and there are more inferred classes than the set
// number of classes to display, then filter the classes to display
// in the chart down to the top scoring classes.
if (this.isMultiClass_(this.modelType, this.multiClass)) {
dataToChart = [];
for (let modelIdx = 0; modelIdx < data.length; modelIdx++) {
let modelDataToChart = {};
if (Object.keys(data[modelIdx]).length >
Number(this.maxInferenceEntriesPerRun)) {
const exampleId = this.selected &&
this.selected.length > 0 ? this.selected[0] : 0;
// Get the class labels of the top scoring classes from the most
// recent inference.
const currentExample = this.examplesAndInferences[exampleId];
const lastInference = currentExample.inferences[
currentExample.inferences.length - 1];
const labels = lastInference[modelIdx].slice(
0, this.maxInferenceEntriesPerRun);
for (let labelIdx = 0; labelIdx < labels.length; labelIdx++) {
const label = labels[labelIdx].label;
modelDataToChart[label] = data[modelIdx][label];
}
} else {
modelDataToChart = data[modelIdx];
}
dataToChart.push(modelDataToChart);
}
}

if (chartType == 'numeric'){
chart = this.makeLineChart(featureName, data);
chart = this.makeLineChart(featureName, dataToChart);
} else if (chartType == 'categorical'){
chart = this.makeBarChart(featureName, data);
chart = this.makeBarChart(featureName, dataToChart);
} else {
console.error('Unknown chartType: ' + chartType);
}
Expand Down