notebook: improve cross-version compatibility #2470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The `manager` and `notebook` modules no longer choke when there are running TensorBoard instances on older or newer versions. We also now silently ignore invalid files. There isn’t really any useful information to report out to the user. Fixes #2453. Fixes #2467. Test Plan: Launch TensorBoard version 1.14.0 (stable), and keep it running in the background. Then, create a new virtualenv with Jupyter and latest nightly TensorBoard. Launch Jupyter, and execute the following cell: ``` %load_ext tensorboard %tensorboard --logdir /tmp/whatever ``` Before this patch, this would successfully launch TensorBoard, but also spam a bunch of “incompatible version” log warnings. Those warnings are now gone. Then run ``` from tensorboard import notebook notebook.list() ``` and note that the list contains _both_ TensorBoards, even though they come from different versions. Prior to this patch, this would have logged a warning and shown only the TensorBoard running on the new code. wchargin-branch: notebook-cross-version
nfelt
approved these changes
Jul 26, 2019
tensorboard/manager.py
Outdated
| filepath, | ||
| exc_info=True, | ||
| ) | ||
| # Ignore unrecognized files. |
Contributor
There was a problem hiding this comment.
We could always log at debug here, if you want. Up to you.
Contributor
Author
There was a problem hiding this comment.
Sure: might as well, and might come in handy.
wchargin-source: 2dd9a9ef1b0ad2b1b8031dc06921c7b1e1141794 wchargin-branch: notebook-cross-version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
managerandnotebookmodules no longer choke when there areolder or newer versions of TensorBoard running.
We also now silently ignore invalid files. There isn’t really any useful
information to report out to the user.
Fixes #2453. Fixes #2467.
Test Plan:
Launch TensorBoard version 1.14.0 (stable), and keep it running in the
background. Then, create a new virtualenv with Jupyter and latest
nightly TensorBoard. Launch Jupyter, and execute the following cell:
Before this patch, this would successfully launch TensorBoard, but also
spam a bunch of “incompatible version” log warnings. Those warnings are
now gone.
Then run
and note that the list contains both TensorBoards, even though they
come from different versions. Prior to this patch, this would have
logged a warning and shown only the TensorBoard running on the new code.
Finally, run
printf '"wat"\n' >/tmp/.tensorboard-info/wat, and re-runnotebook.list(). Note that no warning is printed. Then, increase thelog verbosity with
and re-run
notebook.list()to see a warning.wchargin-branch: notebook-cross-version