core: introduce rules_nodejs and angular shim #2472

stephanwlee · 2019-07-26T20:45:18Z

TensorBoard has been using custom Vulcanization to build the frontend
but we have plans to use better officially Bazel-team supported rule:
rules_nodejs. This adds the WORKSPACE dependency to the repo.

Also, to prove the correctness of the integration, this change also
Angular CLI generated (heavily trimmed down and modified) code with its
build rule.

TensorBoard has been using custom Vulcanization to build the frontend but we have plans to use better officially Bazel-team supported rule: rules_nodejs. This adds the WORKSPACE dependency to the repo. Also, to prove the correctness of the integration, this change also Angular CLI generated (heavily trimmed down and modified) code with its build rule.

stephanwlee · 2019-07-26T21:55:19Z

tsconfig.json

@@ -0,0 +1,18 @@
+{


Do note that, by default, ts_library and necessary rule use "//:tsconfig.json" as the default label for tsconfig field. https://github.com/bazelbuild/rules_nodejs/blob/432f88c8acc47b95ae6f368d3c5b7fe3e65baef7/packages/typescript/src/internal/build_defs.bzl#L424-L425

yarn.lock

nfelt · 2019-07-27T00:28:15Z

package.json

@@ -0,0 +1,49 @@
+{
+  "name": "tensorboard",
+  "version": "1.14.0",


Presumably we'll want some way to keep this number, at a minimum, in sync with our pip package version? Maybe we can add a presubmit check that verifies that this number always matches version.py?

We can do that or we can make this version preposterous like 0. This number is mostly useful only when we are publishing a npm package which we are not (note, private: "true"). Which would you prefer?

package.json

nfelt · 2019-07-27T00:32:02Z

WORKSPACE

 # Keep this version in sync with the BAZEL environment variable defined
 # in our .travis.yml config.
-versions.check(minimum_bazel_version = "0.22.0")
+versions.check(minimum_bazel_version = "0.26.1")


Just to clarify, is 0.26.1 the minimum for any reasonable version of rules_nodejs? Or if we went back a few versions on that, could we retain compatibility across more than one bazel version?

Just to clarify, is 0.26.1 the minimum for any reasonable version of rules_nodejs?

0.26.0 is the minimum version required by rules_nodejs.

nfelt · 2019-07-27T00:32:46Z

BUILD

+exports_files(["tsconfig.json"])
+
+
+ts_config(


Since this level of the Bazel package hierarchy doesn't exist internally, do we know how we're going to sync this and the other files? Or do we not use any of these internally?

Or do we not use any of these internally?

This :)

package.json

yarn.lock

caisq · 2019-07-29T14:36:20Z

Thanks for working on this, @stephanwlee .

cc'ing myself for notifications.

stephanwlee · 2019-07-29T16:12:00Z

Okay, now, I am confident that everything will work as intended. I tried to transfer the new addition internally and I did get everything to build correctly! cl/260512283

stephanwlee · 2019-07-29T18:00:23Z

Here is a small doc on how to manage dependency in the new world. #2003 (comment)

I will update it and keep it up-to-date.

nfelt

Onwards into the bright new Angular dawn! 📐 🌄

nfelt · 2019-07-30T22:24:10Z

package.json

Can we perhaps set this to "0.0.0-unused" just to be extra clear?

wchargin · 2019-08-02T23:22:32Z

🎉

stephanwlee · 2019-08-02T23:23:48Z

💄 ?

Summary: Since #2472, this is needed to alter frontend dependencies; since #2493, it is needed to lint frontend code. Test Plan: Ask a guinea pig to follow these instructions. wchargin-branch: docs-yarn

Summary: Since #2472, this is needed to alter frontend dependencies; since #2493, it is needed to lint frontend code. wchargin-branch: docs-yarn

wchargin · 2019-08-12T20:31:18Z

package.json

+    "@angular/cli": "^8.1.2",
+    "@angular/compiler": "^8.1.2",
+    "@angular/compiler-cli": "^8.1.2",
+    "@bazel/bazel": "^0.23.2",


This PR bumps the Bazel version in WORKSPACE from 0.22.0 to 0.26.1,
but adds a dependency in package.json at version 0.23.2. Is there any
reason for the discrepancy?

Cf. #2534 (comment)

stephanwlee force-pushed the ng branch from 044d113 to 92e9f58 Compare July 26, 2019 21:00

stephanwlee added 3 commits July 26, 2019 14:44

added license

cbde6bd

no we aint MIT licensed. we are apache 2.0

d04911a

no, we don't want to publish npm package

40e2b88

stephanwlee commented Jul 26, 2019

View reviewed changes

nodejs rule require bazel 0.26 above

a69cd47

nfelt reviewed Jul 27, 2019

View reviewed changes

wchargin reviewed Jul 27, 2019

View reviewed changes

package.json Outdated Show resolved Hide resolved

yarn.lock Show resolved Hide resolved

Wrong target

527089f

googlebot added the cla: yes label Jul 29, 2019

stephanwlee requested a review from nfelt July 29, 2019 17:48

caisq mentioned this pull request Jul 30, 2019

[debugger plugin] tensor-widget: Implement some basic features #2457

Closed

nfelt approved these changes Jul 30, 2019

View reviewed changes

package.json Outdated

Copy link

Contributor

nfelt Jul 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we perhaps set this to "0.0.0-unused" just to be extra clear?

nfelt added the core:frontend label Jul 30, 2019

make package.json version useless

c1ab72f

stephanwlee force-pushed the ng branch from efcf1c8 to c1ab72f Compare August 2, 2019 19:48

stephanwlee merged commit 8cd4030 into tensorflow:master Aug 2, 2019

stephanwlee deleted the ng branch August 2, 2019 23:20

wchargin mentioned this pull request Aug 5, 2019

docs: point to Yarn install instructions #2501

Merged

wchargin added a commit that referenced this pull request Aug 5, 2019

docs: point to Yarn install instructions (#2501)

757628a

Summary: Since #2472, this is needed to alter frontend dependencies; since #2493, it is needed to lint frontend code. wchargin-branch: docs-yarn

wchargin reviewed Aug 12, 2019

View reviewed changes

		exports_files(["tsconfig.json"])


		ts_config(

core: introduce rules_nodejs and angular shim #2472

core: introduce rules_nodejs and angular shim #2472

Uh oh!

Conversation

stephanwlee commented Jul 26, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

caisq commented Jul 29, 2019

Uh oh!

stephanwlee commented Jul 29, 2019

Uh oh!

stephanwlee commented Jul 29, 2019

Uh oh!

nfelt left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wchargin commented Aug 2, 2019

Uh oh!

stephanwlee commented Aug 2, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants