Make scalars plugin tests mostly TF 2.x–compatible #2522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: These tests were disabled for two reasons: they used `tf.placeholder`, and they used `tf.contrib.summary` for DB mode tests. This patch revises the implementation of the non–DB mode tests to avoid using placeholders, and enables those tests in all versions of TensorFlow. The DB mode tests still cannot be run in TF 2.x because `create_db_writer` is not exported under any public APIs. Test Plan: Tests pass in current `tf-nightly` and `tf-nightly-2.0-preview`. wchargin-branch: scalars-plugin-tests-tf2x
nfelt
approved these changes
Aug 9, 2019
| feed_dict = {placeholder: [1 + step, 2 + step, 3 + step]} | ||
| s = sess.run(summ, feed_dict=feed_dict) | ||
| writer.add_summary(s, global_step=step) | ||
| placeholder = [1 + step, 2 + step, 3 + step] |
Contributor
There was a problem hiding this comment.
placeholder doesn't really make sense as a name for this since it is no longer an actual placeholder
Contributor
|
Also, this fixes most of the scalars_plugin_test.py entry for #1705 so we should probably update that when this goes in (we can perhaps break out a separate line for the tests that use the db_writer as a straggler cleanup item). |
wchargin-source: 21849b2fe9386a20a8f884b8e103c5e18e17ce3a wchargin-branch: scalars-plugin-tests-tf2x
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
These tests were disabled for two reasons: they used
tf.placeholder,and they used
tf.contrib.summaryfor DB mode tests. This patch revisesthe implementation of the non–DB mode tests to avoid using placeholders,
and enables those tests in all versions of TensorFlow. The DB mode tests
still cannot be run in TF 2.x because
create_db_writeris not exportedunder any public APIs.
Test Plan:
Tests pass in current
tf-nightlyandtf-nightly-2.0-preview.wchargin-branch: scalars-plugin-tests-tf2x