Make plugin_event_accumulator_test TF 2.x–compatible
#2558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: These tests used `tf.contrib.ffmpeg.encode_audio`, but they can actually just use `tf.audio.encode_wav`, which has existed since TensorFlow 1.14. This also makes the encoder itself TF 2.x–compatible. Makes progress toward #1705. Test Plan: Tests pass in both TF 1.x and TF 2.x, and the `run_v1_only` decorators have been removed: ``` $ git grep run_v1_only '*encoder*_test.py' '*audio*_test.py' | wc -l 0 ``` wchargin-branch: audio-tf2x
Summary: Depends on #2557 for compatibility of underlying audio functionality. Other than that, this test just needs to execute a bunch of things in graph mode. Parts could be converted to use more idiomatic TF 2.x style; this is a minimal fix. Makes progress toward #1705. Test Plan: Tests pass in both TF 1.x and TF 2.x, and the test file no longer uses `run_v1_only`. wchargin-branch: pea-tests-tf2x
Contributor
Author
|
Recommend reviewing with |
15 tasks
stephanwlee
approved these changes
Aug 16, 2019
wchargin-source: 7ff58ebf8aa157bc14099aae2dd04f8fd4881902 wchargin-branch: pea-tests-tf2x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Depends on #2557 for compatibility of underlying audio functionality.
Other than that, this test just needs to execute a bunch of things in
graph mode. Parts could be converted to use more idiomatic TF 2.x style;
this is a minimal fix.
Makes progress toward #1705.
Test Plan:
Tests pass in both TF 1.x and TF 2.x, and the test file no longer uses
run_v1_only.wchargin-branch: pea-tests-tf2x