Skip to content

Make data_compat_test TF 2.x–compatible #2559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wchargin merged 3 commits into from
Aug 16, 2019
Merged

Make data_compat_test TF 2.x–compatible #2559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
44bbf04
Make audio-related functionality and tests TF 2.x–compatible
wchargin Aug 16, 2019
9b22840
Make `data_compat_test` TF 2.x–compatible
wchargin Aug 16, 2019
c9765da
[update diffbase]
wchargin Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tensorboard/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,6 @@ py_test(
"//tensorboard/plugins/scalar:metadata",
"//tensorboard/plugins/scalar:summary",
"//tensorboard/util:tensor_util",
"//tensorboard/util:test_util",
],
)

Expand Down
10 changes: 4 additions & 6 deletions tensorboard/data_compat_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
from tensorboard.plugins.scalar import metadata as scalar_metadata
from tensorboard.plugins.scalar import summary as scalar_summary
from tensorboard.util import tensor_util
from tensorboard.util import test_util



Expand Down Expand Up @@ -78,11 +77,11 @@ def test_scalar(self):
low_precision_value = np.array(0x5f3759df).astype('float32').item()
self.assertEqual(low_precision_value, data.item())

@test_util.run_v1_only('v1 audio summary uses contrib')
def test_audio(self):
audio = tf.reshape(tf.linspace(0.0, 100.0, 4 * 10 * 2), (4, 10, 2))
old_op = tf.compat.v1.summary.audio('k488', audio, 44100)
old_value = self._value_from_op(old_op)
with tf.compat.v1.Graph().as_default():
audio = tf.reshape(tf.linspace(0.0, 100.0, 4 * 10 * 2), (4, 10, 2))
old_op = tf.compat.v1.summary.audio('k488', audio, 44100)
old_value = self._value_from_op(old_op)
assert old_value.HasField('audio'), old_value
new_value = data_compat.migrate_value(old_value)

Expand Down Expand Up @@ -185,7 +184,6 @@ def test_new_style_image(self):
assert value.HasField('tensor'), value
self._assert_noop(value)

@test_util.run_v1_only('audio summary uses contrib')
def test_new_style_audio(self):
with tf.compat.v1.Graph().as_default():
audio = tf.reshape(tf.linspace(0.0, 100.0, 4 * 10 * 2), (4, 10, 2))
Expand Down