Skip to content

summary: export v2 symbols as defaults #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephanwlee merged 3 commits into from
Sep 18, 2019
Merged

summary: export v2 symbols as defaults #2670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03feca5
summary: export v2 symbols as defaults
stephanwlee Sep 18, 2019
9f4361c
update the smoke test
stephanwlee Sep 18, 2019
54bcc24
omg stephan is lazy
stephanwlee Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tensorboard/pip_package/test_pip_package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,8 @@ hp.hparams_pb({'optimizer': 'adam', 'learning_rate': 0.02})
# Only test summary scalar, beholder, and mesh summary
python -c "
import tensorboard as tb
tb.summary.scalar_pb('test', 42)
tb.summary.v1.scalar_pb('test', 42)
tb.summary.scalar('test v2', 1337)
from tensorboard.plugins.beholder import Beholder, BeholderHook
from tensorboard.plugins.mesh import summary
"
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/summary/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@
# If the V1 summary API is accessible, load and re-export it here.
try:
from tensorboard.summary import v1
from tensorboard.summary.v1 import *
except ImportError:
pass

# Load the V2 summary API if accessible.
try:
from tensorboard.summary import v2
from tensorboard.summary.v2 import *
except ImportError:
pass

Expand Down
5 changes: 3 additions & 2 deletions tensorboard/summary/summary_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,14 +69,15 @@ class SummaryExportsTest(SummaryExportsBaseTest, unittest.TestCase):
allowed = frozenset(('v1', 'v2'))
plugins = frozenset([
'audio',
'custom_scalar',
'histogram',
'image',
'pr_curve',
'scalar',
'text',
])

def test_plugins_export_pb_functions(self):
self.skipTest('V2 summary API _pb functions are not finalized yet')


class SummaryExportsV1Test(SummaryExportsBaseTest, unittest.TestCase):
module = tb_summary_v1
Expand Down